Make env configurable in helm tutorial #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reshma Abdul Rahim <[email protected]>
rynowak
approved these changes
Apr 9, 2024
willtsai
added a commit
that referenced
this pull request
Apr 25, 2024
* Update docs for v0.32.0 * Update environment logic (#1097) Signed-off-by: Aaron Crawfis <[email protected]> * Superbeeny/adding podspec secrets (#1100) * Adding example on how to access secrets and add them to the container environment Signed-off-by: Nick Beenham <[email protected]> * Adding code tabs where the commands differ between linux/windows Signed-off-by: Nick Beenham <[email protected]> * Apply suggestions from code review Co-authored-by: Will <[email protected]> Signed-off-by: Nick Beenham <[email protected]> * Updates requested from PR review Signed-off-by: Nick Beenham <[email protected]> * nit: add a new line for spacing aesthetics Signed-off-by: Will <[email protected]> --------- Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Make env configurable (#1102) Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Will <[email protected]> * fix(bug): Update index.md (#1113) * fix(bug): Update index.md Fixed a bug in the cleanup script. The command `rad app delete demo -y` results in this output: `Application 'demo' does not exist or has already been deleted.` The command should be: `rad app delete -y` The output will be: `Application first-app deleted` Signed-off-by: Loek Duys <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Fix broken link in faq (#1112) * fix broken link in index.md Signed-off-by: Dan Moseley <[email protected]> * Update index.md Signed-off-by: Dan Moseley <[email protected]> * Update docs/content/concepts/faq/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * add Connections crosslinks to Existing app tutorial (#1103) * add Connections crosslinks to Existing app tutorial Signed-off-by: Will Tsai <[email protected]> * add more crosslinks Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]>
willtsai
added a commit
that referenced
this pull request
Apr 25, 2024
* Update docs for v0.32.0 * Update environment logic (#1097) Signed-off-by: Aaron Crawfis <[email protected]> * Superbeeny/adding podspec secrets (#1100) * Adding example on how to access secrets and add them to the container environment Signed-off-by: Nick Beenham <[email protected]> * Adding code tabs where the commands differ between linux/windows Signed-off-by: Nick Beenham <[email protected]> * Apply suggestions from code review Co-authored-by: Will <[email protected]> Signed-off-by: Nick Beenham <[email protected]> * Updates requested from PR review Signed-off-by: Nick Beenham <[email protected]> * nit: add a new line for spacing aesthetics Signed-off-by: Will <[email protected]> --------- Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Make env configurable (#1102) Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Will <[email protected]> * fix(bug): Update index.md (#1113) * fix(bug): Update index.md Fixed a bug in the cleanup script. The command `rad app delete demo -y` results in this output: `Application 'demo' does not exist or has already been deleted.` The command should be: `rad app delete -y` The output will be: `Application first-app deleted` Signed-off-by: Loek Duys <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Fix broken link in faq (#1112) * fix broken link in index.md Signed-off-by: Dan Moseley <[email protected]> * Update index.md Signed-off-by: Dan Moseley <[email protected]> * Update docs/content/concepts/faq/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> * add Connections crosslinks to Existing app tutorial (#1103) * add Connections crosslinks to Existing app tutorial Signed-off-by: Will Tsai <[email protected]> * add more crosslinks Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Will Tsai <[email protected]> * Update config.toml Signed-off-by: Will <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]>
willtsai
added a commit
that referenced
this pull request
Jun 10, 2024
* Update docs for v0.33.0 * update gh to ado sync workflow to use service principals (#1118) * Update docs for v0.32.0 * Update environment logic (#1097) Signed-off-by: Aaron Crawfis <[email protected]> * Superbeeny/adding podspec secrets (#1100) * Adding example on how to access secrets and add them to the container environment Signed-off-by: Nick Beenham <[email protected]> * Adding code tabs where the commands differ between linux/windows Signed-off-by: Nick Beenham <[email protected]> * Apply suggestions from code review Co-authored-by: Will <[email protected]> Signed-off-by: Nick Beenham <[email protected]> * Updates requested from PR review Signed-off-by: Nick Beenham <[email protected]> * nit: add a new line for spacing aesthetics Signed-off-by: Will <[email protected]> --------- Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Make env configurable (#1102) Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Will <[email protected]> * fix(bug): Update index.md (#1113) * fix(bug): Update index.md Fixed a bug in the cleanup script. The command `rad app delete demo -y` results in this output: `Application 'demo' does not exist or has already been deleted.` The command should be: `rad app delete -y` The output will be: `Application first-app deleted` Signed-off-by: Loek Duys <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Fix broken link in faq (#1112) * fix broken link in index.md Signed-off-by: Dan Moseley <[email protected]> * Update index.md Signed-off-by: Dan Moseley <[email protected]> * Update docs/content/concepts/faq/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> * add Connections crosslinks to Existing app tutorial (#1103) * add Connections crosslinks to Existing app tutorial Signed-off-by: Will Tsai <[email protected]> * add more crosslinks Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Will Tsai <[email protected]> * Update config.toml Signed-off-by: Will <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]> * Update index.md (#1121) Fixed typo `-resource-group myResourceGroup` into `--resource-group myResourceGroup` (added missing `-`) Signed-off-by: Loek Duys <[email protected]> * add new logo types (#1122) Signed-off-by: Will Tsai <[email protected]> * Add CNCF website guidelines (#1123) * Add copyrights Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add trademark Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add trademark Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]>
willtsai
added a commit
that referenced
this pull request
Jun 18, 2024
* Update docs for v0.33.0 * update gh to ado sync workflow to use service principals (#1118) * Update docs for v0.32.0 * Update environment logic (#1097) Signed-off-by: Aaron Crawfis <[email protected]> * Superbeeny/adding podspec secrets (#1100) * Adding example on how to access secrets and add them to the container environment Signed-off-by: Nick Beenham <[email protected]> * Adding code tabs where the commands differ between linux/windows Signed-off-by: Nick Beenham <[email protected]> * Apply suggestions from code review Co-authored-by: Will <[email protected]> Signed-off-by: Nick Beenham <[email protected]> * Updates requested from PR review Signed-off-by: Nick Beenham <[email protected]> * nit: add a new line for spacing aesthetics Signed-off-by: Will <[email protected]> --------- Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Make env configurable (#1102) Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Will <[email protected]> * fix(bug): Update index.md (#1113) * fix(bug): Update index.md Fixed a bug in the cleanup script. The command `rad app delete demo -y` results in this output: `Application 'demo' does not exist or has already been deleted.` The command should be: `rad app delete -y` The output will be: `Application first-app deleted` Signed-off-by: Loek Duys <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Fix broken link in faq (#1112) * fix broken link in index.md Signed-off-by: Dan Moseley <[email protected]> * Update index.md Signed-off-by: Dan Moseley <[email protected]> * Update docs/content/concepts/faq/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> * add Connections crosslinks to Existing app tutorial (#1103) * add Connections crosslinks to Existing app tutorial Signed-off-by: Will Tsai <[email protected]> * add more crosslinks Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Will Tsai <[email protected]> * Update config.toml Signed-off-by: Will <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]> * Update index.md (#1121) Fixed typo `-resource-group myResourceGroup` into `--resource-group myResourceGroup` (added missing `-`) Signed-off-by: Loek Duys <[email protected]> * add new logo types (#1122) Signed-off-by: Will Tsai <[email protected]> * Add CNCF website guidelines (#1123) * Add copyrights Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add trademark Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add trademark Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> * Upmerge --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]>
willtsai
added a commit
that referenced
this pull request
Jun 20, 2024
* Update docs for v0.33.0 * update gh to ado sync workflow to use service principals (#1118) * Update docs for v0.32.0 * Update environment logic (#1097) Signed-off-by: Aaron Crawfis <[email protected]> * Superbeeny/adding podspec secrets (#1100) * Adding example on how to access secrets and add them to the container environment Signed-off-by: Nick Beenham <[email protected]> * Adding code tabs where the commands differ between linux/windows Signed-off-by: Nick Beenham <[email protected]> * Apply suggestions from code review Co-authored-by: Will <[email protected]> Signed-off-by: Nick Beenham <[email protected]> * Updates requested from PR review Signed-off-by: Nick Beenham <[email protected]> * nit: add a new line for spacing aesthetics Signed-off-by: Will <[email protected]> --------- Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Will <[email protected]> * Make env configurable (#1102) Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Will <[email protected]> * fix(bug): Update index.md (#1113) * fix(bug): Update index.md Fixed a bug in the cleanup script. The command `rad app delete demo -y` results in this output: `Application 'demo' does not exist or has already been deleted.` The command should be: `rad app delete -y` The output will be: `Application first-app deleted` Signed-off-by: Loek Duys <[email protected]> * Update docs/content/getting-started/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * Fix broken link in faq (#1112) * fix broken link in index.md Signed-off-by: Dan Moseley <[email protected]> * Update index.md Signed-off-by: Dan Moseley <[email protected]> * Update docs/content/concepts/faq/index.md Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> * add Connections crosslinks to Existing app tutorial (#1103) * add Connections crosslinks to Existing app tutorial Signed-off-by: Will Tsai <[email protected]> * add more crosslinks Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Will Tsai <[email protected]> * Update config.toml Signed-off-by: Will <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]> * Update index.md (#1121) Fixed typo `-resource-group myResourceGroup` into `--resource-group myResourceGroup` (added missing `-`) Signed-off-by: Loek Duys <[email protected]> * add new logo types (#1122) Signed-off-by: Will Tsai <[email protected]> * Add CNCF website guidelines (#1123) * Add copyrights Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add trademark Signed-off-by: Reshma Abdul Rahim <[email protected]> * Add trademark Signed-off-by: Reshma Abdul Rahim <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> * Update docs for v0.34.0 * Update command to view deployed container in tutorial (#1128) * Update command to view deployed container in tutorial Signed-off-by: Filipe Revez <[email protected]> * Fixed another wrong rad app connections command Signed-off-by: Filipe Revez <[email protected]> --------- Signed-off-by: Filipe Revez <[email protected]> * fix ado sync workflow (#1130) Signed-off-by: Will Tsai <[email protected]> * Revert "Merge branch 'v0.33' into v0.34" (#1133) This reverts commit bfba3f3, reversing changes made to e36f280. * fix dead links in contribution guide (#1135) Signed-off-by: Will Tsai <[email protected]> * Rename app connections (#1129) Signed-off-by: Reshma Abdul Rahim <[email protected]> * revert changes Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Aaron Crawfis <[email protected]> Signed-off-by: Nick Beenham <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Loek Duys <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Dan Moseley <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Filipe Revez <[email protected]> Co-authored-by: Radius CI Bot <[email protected]> Co-authored-by: Aaron Crawfis <[email protected]> Co-authored-by: Nick Beenham <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Loek Duys <[email protected]> Co-authored-by: Dan Moseley <[email protected]> Co-authored-by: Filipe Revez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Partially addresses the resource group name confusion documented in radius-project/radius#7341
Sample -radius-project/samples#1046
Issue reference